-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AOT] Clean up some AOT issues in Advanced Paste module #36297
base: main
Are you sure you want to change the base?
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Hi, we've added the "Don't Merge" tag to the PR, since we're trying to keep the repo stable for the release and possible hotfix if necessary. Please don't merge the PR while the tag is still in here. This allows people to review the PR and approve with less fear that it'll get merged 😄 |
…the aot build issue first.
Thanks! We will wait until release complete |
|
||
private object message; | ||
|
||
public string ToJsonString() => JsonSerializer.Serialize(this, AdvancedPasteJsonSerializerContext.Default.PersistedCache); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public string ToJsonString() => JsonSerializer.Serialize(this, AdvancedPasteJsonSerializerContext.Default.PersistedCache); | |
public string ToJsonString() => JsonSerializer.Serialize(this, AdvancedPasteJsonSerializerContext.Default.LogEvent); |
Also, I believe the LogEvent
class should be more defined.
Since we know telemetryEvent.CacheUsed
, telemetryEvent.IsSavedQuery
, telemetryEvent.PromptTokens
, telemetryEvent.CompletionTokens
, telemetryEvent.ModelName
, telemetryEvent.ActionChain
are the properties passed into the anonymous object, defining them in the class will make it cleaner and less prone to potential issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I agree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me consider how to make this interface easy to use.
Summary of the Pull Request
Clean up some AOT build issue. Currently, we can not build the Advanced Paste module with AOT enabled.
blocker:
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed