-
Notifications
You must be signed in to change notification settings - Fork 7.4k
Migrate to MTP #37651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Migrate to MTP #37651
Conversation
b4f4a48
to
33beb64
Compare
This comment has been minimized.
This comment has been minimized.
@Youssef1313 i updated the spell check file for you |
Thanks @crutkas. For the following failure, is that known flakiness?
|
Adding in @yeelam-gordon as his team is helping increase the UI testing here. |
actually adding in @jamrobot as looks like he did some recent touching here too in a different PR |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the test infrastructure to use a more up‐to‐date MSTest framework while updating the test execution pipeline accordingly.
- Refactors RunFancyZonesEditorTest to use an instance TestContext via constructor injection.
- Updates NOTICE.md with newer MSTest dependencies.
- Replaces the VisualStudioTestPlatformInstaller and VSTest tasks with dotnet test commands in the test pipeline.
Reviewed Changes
Copilot reviewed 27 out of 44 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/modules/fancyzones/UITests-FancyZonesEditor/RunFancyZonesEditorTest.cs | Refactors test context management by converting a static field to a readonly instance field and using constructor injection. |
NOTICE.md | Updates MSTest dependency versions to a preview release. |
.pipelines/v2/templates/job-test-project.yml | Replaces the VSTest task with direct dotnet test commands to run UI tests. |
Files not reviewed (17)
- .github/actions/spell-check/expect.txt: Language not supported
- Directory.Build.props: Language not supported
- Directory.Packages.props: Language not supported
- nuget.config: Language not supported
- src/common/UITestAutomation/UITestAutomation.csproj: Language not supported
- src/common/interop/interop-tests/Microsoft.Interop.Tests.csproj: Language not supported
- src/modules/AdvancedPaste/AdvancedPaste.FuzzTests/AdvancedPaste.FuzzTests.csproj: Language not supported
- src/modules/AdvancedPaste/AdvancedPaste.UnitTests/AdvancedPaste.UnitTests.csproj: Language not supported
- src/modules/Hosts/Hosts.FuzzTests/Hosts.FuzzTests.csproj: Language not supported
- src/modules/Hosts/Hosts.Tests/Hosts.Tests.csproj: Language not supported
- src/modules/MouseUtils/MouseJump.Common.UnitTests/MouseJump.Common.UnitTests.csproj: Language not supported
- src/modules/MouseWithoutBorders/MouseWithoutBorders.UnitTests/MouseWithoutBorders.UnitTests.csproj: Language not supported
- src/modules/colorPicker/UnitTest-ColorPickerUI/UnitTest-ColorPickerUI.csproj: Language not supported
- src/modules/fancyzones/UITests-FancyZones/UITests-FancyZones.csproj: Language not supported
- src/modules/fancyzones/UITests-FancyZonesEditor/UITests-FancyZonesEditor.csproj: Language not supported
- src/modules/fancyzones/UnitTests-FancyZonesEditor/UnitTests-FancyZonesEditor.csproj: Language not supported
- src/modules/imageresizer/tests/ImageResizerUITest.csproj: Language not supported
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
@urnotdfs can you help on this PR? You know the best how the WinDriver should be working. |
@yeelam-gordon why not just disable the UI Testing for right now in this PR so we can get the larger fix in @urnotdfs can you please respond here? |
Duplicating #37001, but opening from upstream instead of fork as CI doesn't play nicely with PRs from forks (#37617 is improving that)