Skip to content

Conversation

Youssef1313
Copy link
Member

Duplicating #37001, but opening from upstream instead of fork as CI doesn't play nicely with PRs from forks (#37617 is improving that)

@Youssef1313 Youssef1313 requested a review from a team as a code owner February 26, 2025 14:28
@Youssef1313 Youssef1313 force-pushed the dev/ygerges/migrate-to-mtp branch from b4f4a48 to 33beb64 Compare February 26, 2025 14:28

This comment has been minimized.

@crutkas
Copy link
Member

crutkas commented Feb 27, 2025

@Youssef1313 i updated the spell check file for you

@Youssef1313
Copy link
Member Author

Thanks @crutkas.

For the following failure, is that known flakiness?

2025-02-27T17:49:23.8007336Z    204>D:\a\_work\1\s\x64\Release\tests\Hosts.UITests\net9.0-windows10.0.22621.0\PowerToys.Hosts.UITests.dll : error test failed: TestAddingEntry (1s 178ms): Unable to create instance of class Hosts.UITests.HostModuleTests. Error: OpenQA.Selenium.WebDriverException: A exception with a null response was thrown sending an HTTP request to the remote WebDriver server for URL http://127.0.0.1:4723/session. The status of the exception was UnknownError, and the message was: No connection could be made because the target machine actively refused it. [::ffff:127.0.0.1]:4723 (127.0.0.1:4723) ---> System.Net.WebException: No connection could be made because the target machine actively refused it. [::ffff:127.0.0.1]:4723 (127.0.0.1:4723) ---> System.Net.Http.HttpRequestException: No connection could be made because the target machine actively refused it. [::ffff:127.0.0.1]:4723 (127.0.0.1:4723) ---> System.Net.Sockets.SocketException: No connection could be made because the target machine actively refused it. [::ffff:127.0.0.1]:4723. [D:\a\_work\1\s\src\modules\Hosts\Hosts.UITests\Hosts.UITests.csproj]

@crutkas
Copy link
Member

crutkas commented Feb 28, 2025

Adding in @yeelam-gordon as his team is helping increase the UI testing here.

@crutkas
Copy link
Member

crutkas commented Feb 28, 2025

actually adding in @jamrobot as looks like he did some recent touching here too in a different PR

@crutkas
Copy link
Member

crutkas commented Mar 2, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yeelam-gordon
Copy link
Contributor

/azp run

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the test infrastructure to use a more up‐to‐date MSTest framework while updating the test execution pipeline accordingly.

  • Refactors RunFancyZonesEditorTest to use an instance TestContext via constructor injection.
  • Updates NOTICE.md with newer MSTest dependencies.
  • Replaces the VisualStudioTestPlatformInstaller and VSTest tasks with dotnet test commands in the test pipeline.

Reviewed Changes

Copilot reviewed 27 out of 44 changed files in this pull request and generated no comments.

File Description
src/modules/fancyzones/UITests-FancyZonesEditor/RunFancyZonesEditorTest.cs Refactors test context management by converting a static field to a readonly instance field and using constructor injection.
NOTICE.md Updates MSTest dependency versions to a preview release.
.pipelines/v2/templates/job-test-project.yml Replaces the VSTest task with direct dotnet test commands to run UI tests.
Files not reviewed (17)
  • .github/actions/spell-check/expect.txt: Language not supported
  • Directory.Build.props: Language not supported
  • Directory.Packages.props: Language not supported
  • nuget.config: Language not supported
  • src/common/UITestAutomation/UITestAutomation.csproj: Language not supported
  • src/common/interop/interop-tests/Microsoft.Interop.Tests.csproj: Language not supported
  • src/modules/AdvancedPaste/AdvancedPaste.FuzzTests/AdvancedPaste.FuzzTests.csproj: Language not supported
  • src/modules/AdvancedPaste/AdvancedPaste.UnitTests/AdvancedPaste.UnitTests.csproj: Language not supported
  • src/modules/Hosts/Hosts.FuzzTests/Hosts.FuzzTests.csproj: Language not supported
  • src/modules/Hosts/Hosts.Tests/Hosts.Tests.csproj: Language not supported
  • src/modules/MouseUtils/MouseJump.Common.UnitTests/MouseJump.Common.UnitTests.csproj: Language not supported
  • src/modules/MouseWithoutBorders/MouseWithoutBorders.UnitTests/MouseWithoutBorders.UnitTests.csproj: Language not supported
  • src/modules/colorPicker/UnitTest-ColorPickerUI/UnitTest-ColorPickerUI.csproj: Language not supported
  • src/modules/fancyzones/UITests-FancyZones/UITests-FancyZones.csproj: Language not supported
  • src/modules/fancyzones/UITests-FancyZonesEditor/UITests-FancyZonesEditor.csproj: Language not supported
  • src/modules/fancyzones/UnitTests-FancyZonesEditor/UnitTests-FancyZonesEditor.csproj: Language not supported
  • src/modules/imageresizer/tests/ImageResizerUITest.csproj: Language not supported

Copy link

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@yeelam-gordon yeelam-gordon added the Area-Tests issues that relate to tests label Apr 8, 2025
@yeelam-gordon
Copy link
Contributor

Thanks @crutkas.

For the following failure, is that known flakiness?

2025-02-27T17:49:23.8007336Z    204>D:\a\_work\1\s\x64\Release\tests\Hosts.UITests\net9.0-windows10.0.22621.0\PowerToys.Hosts.UITests.dll : error test failed: TestAddingEntry (1s 178ms): Unable to create instance of class Hosts.UITests.HostModuleTests. Error: OpenQA.Selenium.WebDriverException: A exception with a null response was thrown sending an HTTP request to the remote WebDriver server for URL http://127.0.0.1:4723/session. The status of the exception was UnknownError, and the message was: No connection could be made because the target machine actively refused it. [::ffff:127.0.0.1]:4723 (127.0.0.1:4723) ---> System.Net.WebException: No connection could be made because the target machine actively refused it. [::ffff:127.0.0.1]:4723 (127.0.0.1:4723) ---> System.Net.Http.HttpRequestException: No connection could be made because the target machine actively refused it. [::ffff:127.0.0.1]:4723 (127.0.0.1:4723) ---> System.Net.Sockets.SocketException: No connection could be made because the target machine actively refused it. [::ffff:127.0.0.1]:4723. [D:\a\_work\1\s\src\modules\Hosts\Hosts.UITests\Hosts.UITests.csproj]

@urnotdfs can you help on this PR? You know the best how the WinDriver should be working.

@yeelam-gordon yeelam-gordon added this to the PowerToys 0.92 milestone Apr 8, 2025
@crutkas
Copy link
Member

crutkas commented Apr 14, 2025

@yeelam-gordon why not just disable the UI Testing for right now in this PR so we can get the larger fix in

@urnotdfs can you please respond here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Tests issues that relate to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants