Skip to content

Conversation

jiripolasek
Copy link
Contributor

@jiripolasek jiripolasek commented Aug 29, 2025

Summary of the Pull Request

CmdPal now displays the search box only on pages that derive from ListPage. On ContentPage (forms, etc.), the search box is hidden.

  • Moves keyboard shortcut handling from SearchBox to ShellPage so shortcuts are always handled.
  • Keeps the search box hidden/disabled to preserve layout metrics.
  • Refines focus management to prevent focus jumps during navigation.
  • For ContentPage page's content gains focus automatically (not just form inputs, but now markdown content as well - so you can scroll immediately, for example).
  • Adds accessibility (a11y) tweaks: when navigating to content pages without a visible search box, sets an explicit focus target so screen readers announce a meaningful element. Screen reader will now announce navigation to the page.
  • Adds a title to the main list page - "Home".
Screen.Recording.2025-08-29.180550.mp4

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

CmdPal now displays the search box only on pages that derive from ListPage. On ContentPage (forms, etc.), the search box is hidden.

- Moves keyboard shortcut handling from SearchBox to ShellPage so shortcuts are always handled. 
- Keeps the search box hidden/disabled to preserve layout metrics. 
- Refines focus management to prevent focus jumps during navigation. 
- Adds accessibility (a11y) tweaks: when navigating to content pages without a visible search box, sets an explicit focus target so screen readers announce a meaningful element. Screen reader will now announce navigation to the page.
- Adds a title to the main list page - "Home".
@jiripolasek jiripolasek changed the title CmdPal: Hide search box on content pages CmdPal: Hide search box on content pages [experiment] Aug 29, 2025
@michaeljolley michaeljolley added the Product-Command Palette Refers to the Command Palette utility label Sep 2, 2025
@zadjii-msft
Copy link
Member

this is pretty neat from the video. Anything stopping this from being ready to review?

@jiripolasek
Copy link
Contributor Author

It should be ready, if I recall correctly, but I was waiting for confirmation on the overall design.

@jiripolasek jiripolasek marked this pull request as ready for review September 5, 2025 16:17
@michaeljolley
Copy link
Contributor

@jiripolasek, got a conflict

@jiripolasek
Copy link
Contributor Author

@jiripolasek, got a conflict

The anti-conflict squad of geeky squirrels already knows the drill 🐿️🔧

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product-Command Palette Refers to the Command Palette utility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CmdPal] Incorrect search string in Add Bookmark plugin
3 participants