Fixed keyvisual issue for pt run #41539
Open
+43
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shawn Yuan <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a keyvisual issue for PowerToys Run by implementing a mechanism to prevent unnecessary hotkey conflict detection when settings are updated without hotkey changes.
- Adds a
HotkeyChangedproperty to track when hotkeys are actually modified - Updates the settings dispatch logic to only trigger hotkey updates when necessary
- Prevents incorrect hotkey conflict detection during non-hotkey setting changes
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| PowerLauncherViewModel.cs | Adds hotkey change tracking and sets flag when OpenPowerLauncher hotkey is modified |
| PowerLauncherProperties.cs | Introduces HotkeyChanged property to the settings model |
| settings_window.cpp | Updates module configuration dispatch to conditionally trigger hotkey updates based on the flag |
Comments suppressed due to low confidence (1)
src/settings-ui/Settings.UI/ViewModels/PowerLauncherViewModel.cs:1
- There's a character encoding issue in the comment. 'PowerLauncher's' contains a non-standard apostrophe character (') that should be replaced with a standard apostrophe (').
// Copyright (c) Microsoft Corporation
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Shawn Yuan <[email protected]>
Signed-off-by: Shawn Yuan <[email protected]>
|
@shuaiyuanxx, do we still need this? if we git rid of detection of run v1 first? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed