-
Notifications
You must be signed in to change notification settings - Fork 7.4k
Upgrade WinAppSDK to 1.8 official release #41723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Shawn Yuan <[email protected]>
Signed-off-by: Shawn Yuan <[email protected]>
Signed-off-by: Shawn Yuan <[email protected]>
Signed-off-by: Shawn Yuan <[email protected]>
Signed-off-by: Shawn Yuan <[email protected]>
Signed-off-by: Shawn Yuan <[email protected]>
Signed-off-by: Shawn Yuan <[email protected]>
Signed-off-by: Shawn Yuan <[email protected]>
Signed-off-by: Shawn Yuan <[email protected]>
Signed-off-by: Shawn Yuan <[email protected]>
Signed-off-by: Shawn Yuan <[email protected]>
Signed-off-by: Shawn Yuan <[email protected]>
Signed-off-by: Shawn Yuan <[email protected]>
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Shawn Yuan <[email protected]>
…/PowerToys into shawn/testNewWinAppSDK
} | ||
|
||
if ($Packages.Count -gt 0) { | ||
# Priority: Look for platform-specific MSIX (x64/arm64) first, then fallback to any |
Check failure
Code scanning / check-spelling
Forbidden Pattern Error
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Shawn Yuan <[email protected]>
…/PowerToys into shawn/testNewWinAppSDK
Signed-off-by: Shawn Yuan <[email protected]>
This comment has been minimized.
This comment has been minimized.
…/PowerToys into shawn/testNewWinAppSDK
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the Windows App SDK from version 1.7 to the official 1.8 release across the PowerToys codebase. The upgrade introduces modular WindowsAppSDK packages and updates related dependencies.
Key changes:
- Upgrades Microsoft.WindowsAppSDK from 1.7.250513003 to 1.8.250907003
- Introduces granular WindowsAppSDK component packages (Base, Foundation, WinUI, Runtime, DWrite, InteractiveExperiences, Widgets, AI)
- Updates WebView2 and Windows SDK Build Tools to newer versions
- Enhances CI pipeline to handle multiple MSIX packages
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
src/modules/powerrename/PowerRenameUILib/packages.config | Updates WindowsAppSDK to 1.8 and adds new component packages |
src/modules/powerrename/PowerRenameUILib/PowerRenameUI.vcxproj | Updates project imports and error checking for new WindowsAppSDK structure |
src/modules/cmdpal/extensionsdk/Microsoft.CommandPalette.Extensions/packages.config | Adds new WindowsAppSDK packages and dependencies |
src/modules/cmdpal/extensionsdk/Microsoft.CommandPalette.Extensions/Microsoft.CommandPalette.Extensions.vcxproj | Updates WasdkNuget path reference |
src/modules/cmdpal/Microsoft.Terminal.UI/packages.config | Adds WindowsAppSDK component packages |
src/modules/cmdpal/Microsoft.Terminal.UI/Microsoft.Terminal.UI.vcxproj | Updates project with new WindowsAppSDK imports and error checking |
src/modules/cmdpal/Microsoft.CmdPal.UI/Microsoft.CmdPal.UI.csproj | Adds CI build configuration for MSIX packaging |
src/modules/cmdpal/ExtensionTemplate/TemplateCmdPalExtension/Directory.Packages.props | Updates WindowsAppSDK version reference |
src/modules/MeasureTool/MeasureToolCore/packages.config | Updates WindowsAppSDK to 1.8 and adds component packages |
src/modules/MeasureTool/MeasureToolCore/PowerToys.MeasureToolCore.vcxproj | Updates project imports and error checking for WindowsAppSDK 1.8 |
Directory.Packages.props | Updates global package versions for WebView2, Windows SDK Build Tools, and WindowsAppSDK |
.pipelines/v2/templates/job-build-project.yml | Enhances CmdPal MSIX package detection logic for CI builds |
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Remove the unnecessary empty lines between imports to maintain consistency with the rest of the project file formatting.
Copilot uses AI. Check for mistakes.
<Error Condition="!Exists('..\..\..\..\packages\Microsoft.WindowsAppSDK.Runtime.1.8.250907003\build\native\Microsoft.WindowsAppSDK.Runtime.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\..\..\packages\Microsoft.WindowsAppSDK.Runtime.1.8.250907003\build\native\Microsoft.WindowsAppSDK.Runtime.props'))" /> | ||
<Error Condition="!Exists('..\..\..\..\packages\Microsoft.WindowsAppSDK.Runtime.1.8.250907003\build\native\Microsoft.WindowsAppSDK.Runtime.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\..\..\..\packages\Microsoft.WindowsAppSDK.Runtime.1.8.250907003\build\native\Microsoft.WindowsAppSDK.Runtime.targets'))" /> | ||
<Error Condition="!Exists('..\..\..\..\packages\Microsoft.WindowsAppSDK.DWrite.1.8.25090401\build\Microsoft.WindowsAppSDK.DWrite.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\..\..\packages\Microsoft.WindowsAppSDK.DWrite.1.8.25090401\build\Microsoft.WindowsAppSDK.DWrite.props'))" /> | ||
<Error Condition="!Exists('..\..\..\..\packages\Microsoft.WindowsAppSDK.DWrite.1.8.25090401\build\Microsoft.WindowsAppSDK.DWrite.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\..\..\..\packages\Microsoft.WindowsAppSDK.DWrite.1.8.25090401\build\Microsoft.WindowsAppSDK.DWrite.targets'))" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Remove the trailing whitespace at the end of this line to maintain code cleanliness.
<Error Condition="!Exists('..\..\..\..\packages\Microsoft.WindowsAppSDK.DWrite.1.8.25090401\build\Microsoft.WindowsAppSDK.DWrite.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\..\..\..\packages\Microsoft.WindowsAppSDK.DWrite.1.8.25090401\build\Microsoft.WindowsAppSDK.DWrite.targets'))" /> | |
<Error Condition="!Exists('..\..\..\..\packages\Microsoft.WindowsAppSDK.DWrite.1.8.25090401\build\Microsoft.WindowsAppSDK.DWrite.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\..\..\..\packages\Microsoft.WindowsAppSDK.DWrite.1.8.25090401\build\Microsoft.WindowsAppSDK.DWrite.targets'))" /> |
Copilot uses AI. Check for mistakes.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
This reverts commit 17b880d.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. These words are not needed and should be removedadvancedpasteui advancedpasteuishortcut allpc fff hotkeylockmachine hotkeyreconnect hotkeyswitch hotkeytoggleeasymouse imagetotext imagetotextshortcut LOCKMACHINE measuretool mousepointercrosshairs pasteashtmlfile pasteashtmlfileshortcut pasteasjson pasteasjsonshortcut pasteasmarkdown pasteasmarkdownshortcut pasteasplaintext pasteasplaintextshortcut pasteaspngfile pasteaspngfileshortcut pasteastxtfile pasteastxtfileshortcut powerocr projitems reparenthotkey thumbnailhotkey TOGGLEEASYMOUSE transcodetomp TruSome files were automatically ignored 🙈These sample patterns would exclude them:
You should consider adding them to:
File matching is via Perl regular expressions. To check these files, more of their words need to be in the dictionary than not. You can use To update file exclusions and remove the previously acknowledged and now absent words, you could run the following commands... in a clone of the [email protected]:microsoft/PowerToys.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/c635c2f3f714eec2fcf27b643a1919b9a811ef2e/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/17708338367/attempts/1' &&
git commit -m 'Update check-spelling metadata' Forbidden patterns 🙅 (1)In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves. These forbidden patterns matched content: Should be
|
Summary of the Pull Request
This pull request primarily updates project dependencies to newer versions, especially for the Windows App SDK and related packages, and improves the build pipeline's logic for selecting MSIX packages. These changes ensure compatibility with the latest SDK features and provide more robust package selection during builds.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Dependency and SDK upgrades:
Microsoft.WindowsAppSDK
and related packages (Base, Foundation, WinUI, Runtime, DWrite, InteractiveExperiences, Widgets, AI) to version 1.8.x in all relevant project files, includingDirectory.Packages.props
,.vcxproj
,.csproj
, andpackages.config
files. This also involved updating import paths and error checks for the new package structure. [1] [2] [3] [4] [5] [6] [7] [8]Microsoft.Web.WebView2
to version 1.0.3179.45 andMicrosoft.Windows.SDK.BuildTools
to 10.0.26100.4948 inDirectory.Packages.props
. [1] [2]Build and packaging improvements:
job-build-project.yml
) to prioritize platform-specific packages (x64/arm64) and provide clearer logging and error handling when no packages are found.Microsoft.CmdPal.UI.csproj
to disable Appx bundling and set a specific test directory for Appx packages during CI builds, improving build output organization.These updates help ensure the project stays current with the latest SDKs and improves reliability and transparency in the build process.
Validation Steps Performed