Removing WCT 7.x references #41733
Open
Removing WCT 7.x references #41733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the PowerToys Settings UI by migrating from Community Toolkit 7.x components to the latest 8.0 version and Labs packages. The main purpose is to improve the appearance and functionality of the release notes display while removing outdated dependencies.
- Replaces MarkdownTextBlock from the 7.x UI.Controls package with the newer Labs.WinUI.Controls.MarkdownTextBlock
- Updates WrapPanel and converter references from 7.x to 8.0 versions
- Removes unused namespaces and dependencies related to the old toolkit versions
Reviewed Changes
Copilot reviewed 40 out of 40 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Directory.Packages.props | Updates package versions, removes 7.x MarkdownTextBlock, updates Labs package version |
| PowerToys.Settings.csproj | Switches package reference from old UI.Controls.Markdown to Labs MarkdownTextBlock |
| Multiple XAML files | Updates namespace declarations from tk7controls to tkcontrols for MarkdownTextBlock usage |
| OobeWhatsNew.xaml.cs | Adds MarkdownConfig setup and removes old LinkClicked event handler |
| NOTICE.md | Removes reference to deprecated CommunityToolkit.WinUI.UI.Controls.Markdown package |
src/settings-ui/Settings.UI/SettingsXAML/OOBE/Views/OobeWhatsNew.xaml.cs
Outdated
Show resolved
Hide resolved
src/settings-ui/Settings.UI/SettingsXAML/OOBE/Views/OobeWhatsNew.xaml
Outdated
Show resolved
Hide resolved
|
@yeelam-gordon do you know why the CI is failing? looks like it's complaining about .deps files? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR introduces the following changes:
No visual or behavior changes, except for the release notes that now look better :):
Before:
After:
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed