Skip to content

Conversation

jjmartinezQT
Copy link
Contributor

This PR brings the capability to change the operation mode in the Rohde & Schwartz SGS100A instrument. The two operation modes the instrument support are:

  • NORMal (normal operation mode, default.)
  • BBBYpass (bypass operation mode).

When resetting the instrument, the operation mode defaults to NORMal.

@jjmartinezQT jjmartinezQT requested a review from a team as a code owner July 28, 2025 14:45
@astafan8 astafan8 enabled auto-merge August 5, 2025 17:00
Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the contribution!!

Copy link

codecov bot commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.72%. Comparing base (5a95275) to head (846e3ed).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7344   +/-   ##
=======================================
  Coverage   59.72%   59.72%           
=======================================
  Files         347      347           
  Lines       31227    31229    +2     
=======================================
+ Hits        18650    18652    +2     
  Misses      12577    12577           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jenshnielsen
Copy link
Collaborator

@jjmartinezQT This is ready to merge. However before we can merge it you are required to accept the CLA (see bot comment above)

@jjmartinezQT
Copy link
Contributor Author

@jjmartinezQT This is ready to merge. However before we can merge it you are required to accept the CLA (see bot comment above)

Thanks! I am awaiting internal company approval with the ok about the CLA and will accept it as soon as I can.

@astafan8
Copy link
Contributor

@jjmartinezQT any news on CLA agreement?

@jjmartinezQT
Copy link
Contributor Author

jjmartinezQT commented Sep 14, 2025

@jjmartinezQT please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Qilimanjaro Quantum Tech"

@jjmartinezQT
Copy link
Contributor Author

@jjmartinezQT any news on CLA agreement?

Sorry for the delay, just agreed to it.

Cheers.

@astafan8 astafan8 added this pull request to the merge queue Sep 15, 2025
Merged via the queue into microsoft:main with commit cf9a721 Sep 15, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants