Add New Copper Mountain M5065 and M5180 Drivers #7497
Conversation
…hub.com/trlemon/Qcodes into tlemon/add-copper-mountain-m5065-driver
…hub.com/trlemon/Qcodes into tlemon/add-copper-mountain-m5065-driver
trlemon
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7497 +/- ##
==========================================
- Coverage 59.73% 59.66% -0.07%
==========================================
Files 347 350 +3
Lines 31242 31468 +226
==========================================
+ Hits 18661 18774 +113
- Misses 12581 12694 +113 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| s22_raw = self.ask("CALC1:TRAC4:DATA:FDAT?") | ||
|
|
||
| # Get data as numpy array | ||
| freq = np.fromstring(freq_raw, dtype=float, sep=",") |
There was a problem hiding this comment.
doesn't this assume that format parameter is set to a certain value or does this work for all the formats?
There was a problem hiding this comment.
This assumes that the data transfer format is ascii (which is the default). It will throw an error if the data transfer format is set to "real" or "real32".
| self.instrument.write(f"CALC1:PAR1:DEF {self.name}") | ||
| self.instrument.trigger_source("bus") # set the trigger to bus | ||
| self.instrument.write("TRIG:SEQ:SING") # Trigger a single sweep | ||
| self.instrument.ask("*OPC?") # Wait for measurement to complete |
There was a problem hiding this comment.
same comment about timeout here as well
| self.instrument.ask("*OPC?") # Wait for measurement to complete | ||
|
|
||
| # get data from instrument | ||
| self.instrument.write("CALC1:TRAC1:FORM SMITH") # ensure correct format |
There was a problem hiding this comment.
does this ignore the format parameter defined in instrument's init? that'd be confusing for users, i beleive.
| # get data from instrument | ||
| self.instrument.write("CALC1:TRAC1:FORM SMITH") # ensure correct format | ||
| sxx_raw = self.instrument.ask("CALC1:TRAC1:DATA:FDAT?") | ||
| self.instrument.write("CALC1:TRAC1:FORM MLOG") |
There was a problem hiding this comment.
why is the format set to something and then data is not asked anymore?
Co-authored-by: Mikhail Astafev <[email protected]>
Summary of Changes
Notes
qcodes_contrib_driversfor the CMT M5180