Solve std140 layout violations #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for Dxcompiler when targeting GLSL or ESSL
|
Is this a std140 only issue, or it also affect other layout? If the vk-use-gl-layout is turned on for all GLSL and ESSL, layouts other than std140 can be changed, too. |
gongminmin
suggested changes
Sep 24, 2020
|
|
I only tested this for std140, but according to this document it also applies to std430 when using storage buffers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been running into std140 layout violations when targeting GLSL. Adding the fvk-use-gl-layout option to DXC solved this. My implementation might not be exactly how you want to do this, but it seems to me that fvk-use-gl-layout should be included somehow.