Fixed error in grounding causing inability to add documents #102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in the adding of documents in the grounding module. Dcouments implement the llama-index's Document interface in which the .text attribute is read only. The add_document method attempted to directly write the attribute with the results of the sanitize_raw_string function, causing a runtime error. For example when attempting to add mental faculties in the investment_firm.ipynb example:
Changes Made
Testing
Tested grounding for files in a directory and also for a web page within the context of the investment_firm example.