Change return type of CredentialsContainer.create for WebAuthn #1742
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi developers,
The return value for CredentialsContainer.create is one of
FederatedCredential
,PasswordCredential
, andPublicKeyCredential
according to https://developer.mozilla.org/en-US/docs/Web/API/CredentialsContainer/create#return_value
The return types are subclass of Credential. So I changed using
PublicKeyCredential
fromCredential
. Note thatFederatedCredential
andPasswordCredential
haven't been implemented yet, therefore, I didn't use them. I'll also try to create them after I learn the manners of this repo.Thank you for reading my PR.