-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS Typed OM get property return types #1864
Open
ophirbucai
wants to merge
9
commits into
microsoft:main
Choose a base branch
from
ophirbucai:feat/improve-css-typed-om-style-property-map-types
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
CSS Typed OM get property return types #1864
ophirbucai
wants to merge
9
commits into
microsoft:main
from
ophirbucai:feat/improve-css-typed-om-style-property-map-types
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narrow down return type of `StylePropertyMapReadOnly.get()` to match CSS Types OM specification. Properties now return their specific CSSStyleValue sub classes: - CSSUnitValue - CSSKeywordValue - CSSTransformValue - Default: CSSStyleValue This change provides better type safety and autocompletion when working with `computedStyleMap()`. Changes: - Added specific return types for common CSS properties in StylePropertyMap - Maintained backwards compatibility with fallback to `CSSStyleValue` - Included links to MDN documentation Tests: - `hereby runtests` completed successfully in the TypeScript repo
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
ophirbucai
changed the title
feat(lib.dom): Improve CSS Typed OM property return types
Feature: Improve CSS Typed OM property return types
Dec 22, 2024
…y.get() Move type definitions to overrideTypes to generate corresponding return types, include MDN references Closes microsoft#1863
@microsoft-github-policy-service agree |
ophirbucai
changed the title
Feature: Improve CSS Typed OM property return types
CSS Typed OM get property return types (#1863)
Dec 22, 2024
ophirbucai
changed the title
CSS Typed OM get property return types (#1863)
CSS Typed OM get property return types
Dec 22, 2024
CSSUnparsedValue for custom properties --* CSSMathValue for properties accepting calc() CSSImageValue for properties accepting url() Separate properties by their return values MDN references for each overloaded function definition
I realized that there are more type definitions such as:
The process involved:
Hope it helps people use computedStyleMap(). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Narrow down return type of
StylePropertyMapReadOnly.get()
to match CSS Types OM specification. Properties now return their specific CSSStyleValue sub classes:This change provides better type safety and autocompletion when working with
computedStyleMap()
.Changes:
CSSStyleValue