ATA: node: module resolution (#3191)

Co-authored-by: Jake Bailey <[email protected]>
microsoft · Jul 30, 2024 · 1d0af97 · 1d0af97
1 parent ce2f2e9
commit 1d0af97
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/.changeset/plenty-deers-visit.md b/.changeset/plenty-deers-visit.md
@@ -0,0 +1,5 @@
+---
+"@typescript/ata": patch
+---
+
+Always treat `node:` modules as Node, expand list of known Node modules
diff --git a/packages/ata/src/edgeCases.ts b/packages/ata/src/edgeCases.ts
@@ -24,6 +24,7 @@ export const mapModuleNameToModule = (moduleSpecifier: string) => {
     "http2",
     "https",
     "inspector",
+    "inspector/promises",
     "module",
     "net",
     "os",
@@ -57,7 +58,7 @@ export const mapModuleNameToModule = (moduleSpecifier: string) => {
     "zlib",
   ]
 
-  if (builtInNodeMods.includes(moduleSpecifier.replace("node:", ""))) {
+  if (moduleSpecifier.indexOf("node:") === 0 || builtInNodeMods.includes(moduleSpecifier)) {
     return "node"
   }
 

diff --git a/packages/ata/tests/edgeCases.spec.ts b/packages/ata/tests/edgeCases.spec.ts
@@ -9,6 +9,11 @@ describe(mapModuleNameToModule, () => {
     expect(mapModuleNameToModule("node:fs")).toEqual("node")
   })
 
+  it("handles mandatorily-prefixed node: identifiers", () => {
+    expect(mapModuleNameToModule("node:test")).toEqual("node")
+    expect(mapModuleNameToModule("test")).toEqual("test")
+  })
+
   it("strips module filepaths", () => {
     expect(mapModuleNameToModule("lodash/identity")).toEqual("lodash")
     expect(mapModuleNameToModule("@org/lodash/identity")).toEqual("@org/lodash")