Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to pnpm and changesets #3079

Merged
merged 44 commits into from
May 21, 2024
Merged

Migrate to pnpm and changesets #3079

merged 44 commits into from
May 21, 2024

Conversation

jakebailey
Copy link
Member

@jakebailey jakebailey commented Apr 25, 2024

This switches the repo to pnpm/changesets, the monorepo and deployment method we use for dt-tools and attw (and me personally).

Notably:

  • Internal deps are now marked as workspace:*, so we don't need to do the bumping manually.
  • Publishing is now via pnpm publish -r, which rewrites the specifiers automatically.
  • Changesets auto-bumps the version numbers themselves.
  • Builds are a lot faster (multiple minutes better).

TODO:

@jakebailey jakebailey added the deploy-preview Enables automatic deployments to preview environments on a PR label Apr 25, 2024
@jakebailey jakebailey changed the title Migrate to pnpm Migrate to pnpm and changesets May 15, 2024
@jakebailey jakebailey marked this pull request as ready for review May 16, 2024 00:03
@jakebailey
Copy link
Member Author

Hey, it works.

@jakebailey
Copy link
Member Author

Yay, got it working on all OSs.

Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing. What’s the remaining CI status thing?

@jakebailey
Copy link
Member Author

Amazing. What’s the remaining CI status thing?

GitHub is configured to require the CI check named "tests" but that doesn't work when it turns into a matrix as the name changed. Which is silly. I plan to use this trick: https://github.com/microsoft/typescript-benchmarking/blob/7371a75e3d5862eaffabaca749b94cfa9b934bc9/.github/workflows/ci.yml#L132

@jakebailey
Copy link
Member Author

This is looking good to go, but I'm going to do one last check and pack each package and compare it to what's on npm to ensure that the build is actually working as intended.

@jakebailey
Copy link
Member Author

Diffing was fruitful and found a few issues. The packages that can be published after this PR should be correct, plus or minus that the other gatsby 5 and such PR updated some deps.

Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-plant-05c166c10-3079.centralus.5.azurestaticapps.net

@jakebailey jakebailey merged commit 46eba14 into microsoft:v2 May 21, 2024
8 checks passed
@jakebailey jakebailey deleted the pnpm branch May 24, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy-preview Enables automatic deployments to preview environments on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants