Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

complete punctuations for consistency #3153

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from
Open

complete punctuations for consistency #3153

wants to merge 1 commit into from

Conversation

hanyujie2002
Copy link
Contributor

No description provided.

@jakebailey
Copy link
Member

Consistency with what?

@hanyujie2002
Copy link
Contributor Author

Consistency with what?

Line 251 and 253 have trailing periods. Consequently, I added periods to the end of other similar lines to align them with these two lines.

@jakebailey
Copy link
Member

Isn't it the case that the periods are the ones that are out of place?

@hanyujie2002
Copy link
Contributor Author

Um, both options are fine, from my perspective. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ByteJoseph ByteJoseph ByteJoseph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hanyujie2002 @jakebailey @ByteJoseph