Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Playground handle bigint in logs #3169

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Fix: Playground handle bigint in logs #3169

merged 2 commits into from
Jun 28, 2024

Conversation

lukaw3d
Copy link
Contributor

@lukaw3d lukaw3d commented Jun 28, 2024

Related to #3168

Playground Logs should display bigints in logged objects

Before:
https://www.typescriptlang.org/play/?target=7#code/PTAEAEBcEMCcHMCmkBcoCiBlATABjwFADGA9gHYDOJANogHTUnwAUA3qNGgIw+9-8DBQ4ULKgAvgEoCQA

  • // @target: ES2020
console.log({ a: 11111111111111111111111111111111111111111111111111111n })
  • Click "Run"

  • [ERR]: "Executed JavaScript Failed:"
    [ERR]: Do not know how to serialize a BigInt

After:

  • [LOG]: {
    "a": "BigInt('11111111111111111111111111111111111111111111111111111')"
    }

@lukaw3d lukaw3d mentioned this pull request Jun 28, 2024
Open
@jakebailey jakebailey added the deploy-preview Enables automatic deployments to preview environments on a PR label Jun 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-plant-05c166c10-3169.centralus.5.azurestaticapps.net

@jakebailey
Copy link
Member

Seems to work: https://victorious-plant-05c166c10-3169.centralus.5.azurestaticapps.net/play/?target=7#code/PTAEAEBcEMCcHMCmkBcoCiBlATABjwFADGA9gHYDOJANogHTUnwAUA3qNGgIw+9-8DBQ4ULKgAvgEoCQA

@jakebailey jakebailey merged commit 309e3e3 into microsoft:v2 Jun 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey jakebailey approved these changes

Assignees
No one assigned
Labels
deploy-preview Enables automatic deployments to preview environments on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukaw3d @jakebailey