Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add print query to the website #3205

Open
wants to merge 3 commits into
base: v2
Choose a base branch
from

Conversation

a0m0rajab
Copy link

@a0m0rajab a0m0rajab commented Aug 17, 2024

This PR adds print query to the website and show a minimum example of using pagebreak feature.

The no-print class hide the element on print, and the pagebreak add new page before the related div.
Here is the first issue about this: #3204

This PR improve printing a webpage and hide the unnecessary details here is an example:

Before After
image image
image image

Page breaks should be added and tested manually which requires a lot of work that I decided to do only if this approach were approved.

@a0m0rajab
Copy link
Author

@microsoft-github-policy-service agree

@a0m0rajab
Copy link
Author

@jakebailey hey, is there anything I am missing in this pr? I would love to get your thoughts about it

@jakebailey
Copy link
Member

It's not clear to me how this scales; surely other pages would need this? These are explicit page breaks; how would we keep them in the right place and not forget some or add some where they aren't needed?

It just feels like there should be a better solution to this problem than manually breaking pages.

@a0m0rajab
Copy link
Author

Thanks for the answer. If you want, we can split this PR into two different PRs, one to fix the headers that hide the text behind it and the other to discuss the page breaks,

The main issue here is that we have extra pages and hidden texts because of the header and footers that are available on the website.

As for scaling I just did a double check and found another property that we can use for the code, I will check it and ping you.

@a0m0rajab
Copy link
Author

@jakebailey Thanks for your suggestion, we have a better and cleaner code now.
The code I wrote avoids the breaks for code blocks and works well.

@a0m0rajab
Copy link
Author

@jakebailey is there anything I need to do for this?

@jakebailey jakebailey added the deploy-preview Enables automatic deployments to preview environments on a PR label Nov 8, 2024
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-plant-05c166c10-3205.centralus.5.azurestaticapps.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy-preview Enables automatic deployments to preview environments on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants