Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify --diagnostics report units #293

Open
JonasBa opened this issue Feb 11, 2022 · 2 comments
Open

Clarify --diagnostics report units #293

JonasBa opened this issue Feb 11, 2022 · 2 comments

Comments

@JonasBa
Copy link

JonasBa commented Feb 11, 2022

I've been recently looking at parsing --diagnostics output to report to out metrics service so that we can monitor compile times and while attempting to normalize values to a common unit (e.g. durations to seconds and memory used to MB), I've noticed that the docs are not very clear about the metric definitions and their respective units.

I would love if the docs specified what are the possible units that may be reported for each metric. For instance, can Total time be reported in milliseconds or even minutes right now? I see that memory used is reported as K, I assume that is kilobytes, but I'm not sure.

Less importantly, but in a similar vein, the duration timings (parse, bind, check, emit and total time) do not specify if these metrics are reported in wall time or CPU time. (it doesnt make much difference for our purposes, but it would be good to know how the metric may be affected).

If someone can point me to the relevant files where these metrics are measured, I would happy to take a stab at opening a PR :)

Thanks so much!

@orta
Copy link
Contributor

orta commented May 12, 2022

/cc @amcasey

Most of the work happens in the mega-file checker.ts ( you can use find in that file for 'performance' and you'll start hitting some of those cases with in-file searches like performance.mark and tracing

@amcasey
Copy link
Member

amcasey commented May 19, 2022

Sorry, my notifications were messed up. Code is here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants