Replace awkward last-element selection pattern with 'lastOrUndefined' #2996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -267,7 +267,7 @@ var ts; | |||
| var sourceMapNameIndexMap = {}; | |||
| var sourceMapNameIndices = []; | |||
| function getSourceMapNameIndex() { | |||
| return sourceMapNameIndices.length ? sourceMapNameIndices[sourceMapNameIndices.length - 1] : -1; | |||
| return sourceMapNameIndices.length ? lastOrUndefined(sourceMapNameIndices) : -1; | |||
There was a problem hiding this comment.
lastOrUndefined is for calling on arrays that might be empty. You should never actually get undefined back in these cases, and we'd want to throw if you did. We should just have an 'last' functoin that only works on non-empty arrays, and throws otherwise.
|
👍 |
DanielRosenwasser
force-pushed
the
lastOrUndefinedReplacement
branch
from
a9c46e7 to
9460fb5
Compare
DanielRosenwasser
added a commit
that referenced
this pull request
May 4, 2015
Replace awkward last-element selection pattern with 'lastOrUndefined'
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.