-
Notifications
You must be signed in to change notification settings - Fork 13k
Revert PR 61928 #62423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Revert PR 61928 #62423
Conversation
…microsoft#61928)" This reverts commit 02672d2.
Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page. Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reverts changes from PR #61928 to address a crashing issue (#62188). The reversion undoes modifications to JSX token handling that were causing downstream problems, specifically changes related to how JSX closing tags and language variants are processed.
- Reverts JSX token handling changes that replaced
LessThanSlashToken
with separateLessThanToken
andSlashToken
tokens - Removes language variant handling from scanner operations
- Updates test expectations to match the reverted token classification behavior
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
File | Description |
---|---|
tests/cases/fourslash/syntacticClassificationsJsx1.ts | Updates test expectations for JSX closing tag token classification |
tests/cases/fourslash/syntacticClassificationsJsx2.ts | Updates test expectations for JSX closing tag token classification with namespaced elements |
src/services/utilities.ts | Reverts JSX closing element token kind check from LessThanToken back to LessThanSlashToken |
src/services/services.ts | Removes language variant handling from scanner operations in createChildren function |
src/services/completions.ts | Reverts JSX-related token kind checks from SlashToken back to LessThanSlashToken |
src/compiler/types.ts | Removes languageVariant property from SourceFileLike interface |
@typescript-bot cherry-pick this to release-5.9 |
Hey, @jakebailey! I've created #62425 for you. |
Fixes #62188
This reverts #61928
I'm not sure if it's worth the crashing it seems to be causing downstream. Some things have been fixed, but not everything.
Corsa still has this fix (it has to), so everyone will have to deal with it at some point, but...
Ref:
TypeScript
5.9 breaks rules when linting TSX files eslint-stylistic/eslint-stylistic#915