Skip to content

Conversation

jakebailey
Copy link
Member

@jakebailey jakebailey commented Sep 9, 2025

Fixes #62188

This reverts #61928

I'm not sure if it's worth the crashing it seems to be causing downstream. Some things have been fixed, but not everything.

Corsa still has this fix (it has to), so everyone will have to deal with it at some point, but...

Ref:

@Copilot Copilot AI review requested due to automatic review settings September 9, 2025 16:58
@github-project-automation github-project-automation bot moved this to Not started in PR Backlog Sep 9, 2025
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Sep 9, 2025
@typescript-bot
Copy link
Collaborator

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts changes from PR #61928 to address a crashing issue (#62188). The reversion undoes modifications to JSX token handling that were causing downstream problems, specifically changes related to how JSX closing tags and language variants are processed.

  • Reverts JSX token handling changes that replaced LessThanSlashToken with separate LessThanToken and SlashToken tokens
  • Removes language variant handling from scanner operations
  • Updates test expectations to match the reverted token classification behavior

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
tests/cases/fourslash/syntacticClassificationsJsx1.ts Updates test expectations for JSX closing tag token classification
tests/cases/fourslash/syntacticClassificationsJsx2.ts Updates test expectations for JSX closing tag token classification with namespaced elements
src/services/utilities.ts Reverts JSX closing element token kind check from LessThanToken back to LessThanSlashToken
src/services/services.ts Removes language variant handling from scanner operations in createChildren function
src/services/completions.ts Reverts JSX-related token kind checks from SlashToken back to LessThanSlashToken
src/compiler/types.ts Removes languageVariant property from SourceFileLike interface

@jakebailey
Copy link
Member Author

@typescript-bot cherry-pick this to release-5.9

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 9, 2025

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
cherry-pick this to release-5.9 ✅ Started ✅ Results

@typescript-bot
Copy link
Collaborator

Hey, @jakebailey! I've created #62425 for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
Status: Not started
Development

Successfully merging this pull request may close these issues.

Maxinum call stack size exceeded for 5.9.x
2 participants