Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file.Delete() if file.Exists #1787

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

file.Delete() if file.Exists #1787

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9db18a1
file.Delete() if file.Exists
ankurash Sep 2, 2022
4a18fa3
put file.Delete() in try catch so it doesn't exit midway
ankurash Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion GVFS/GVFS.Common/FileSystem/PhysicalFileSystem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,10 @@ public virtual void DeleteDirectory(string path, bool recursive = true, bool ign
foreach (FileInfo file in directory.GetFiles())
{
file.Attributes = FileAttributes.Normal;
file.Delete();
if(file.Exists)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is still a race here that the file exists and is then deleted before the delete is invoked; a better solution is to perform the delete unconditionally and then catch the exception if the file does not exist

{
file.Delete();
}
}

foreach (DirectoryInfo subDirectory in directory.GetDirectories())
Expand Down