Remove redundant static_cast in container network type assignment #13912
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Removes unnecessary
static_cast<enum WSLA_CONTAINER_NETWORK_TYPE>inWSLAContainerLauncher.cppthat became redundant after the member variable type was changed fromintto the enum type.PR Checklist
Detailed Description of the Pull Request / Additional comments
The
m_containerNetworkTypemember variable type was changed frominttoWSLA_CONTAINER_NETWORK_TYPEin commit e0153c3, but the implementation still contained a static_cast when assigning to the options struct:The cast is now unnecessary since both the source and destination are the same enum type. This improves type safety by removing the ability to bypass enum type checking.
Also added
_codeql_detected_source_rootto.gitignoreto prevent committing this CodeQL build artifact.Validation Steps Performed
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.