Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 15, 2025

Summary of the Pull Request

Verified that the bot's suggestion regarding network mode assertions in WSLATests.cpp has already been correctly implemented. No code changes required.

PR Checklist

  • Closes: N/A - verification only
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

The automated review suggested changing a test assertion to expect '[\"none\"]' instead of '[\"host\"]' for a container created with WSLA_CONTAINER_NETWORK_NONE.

Current implementation already has this correct:

  • HOST network test (line 1486): Creates container with WSLA_CONTAINER_NETWORK_HOST → expects '[\"host\"]' (line 1495)
  • NONE network test (line 1517): Creates container with WSLA_CONTAINER_NETWORK_NONE → expects '[\"none\"]' (line 1526)

Both assertions correctly match their respective network types. The suggestion appears to reference outdated line numbers from the original PR.

Validation Steps Performed

  • Reviewed test code structure for network mode assertions
  • Verified each network type (HOST, NONE) has correct expected network label
  • Confirmed no mismatches between container creation and assertion

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] WIP address feedback on container network mode implementation Verify network mode test assertions are correct Dec 15, 2025
Copilot AI requested a review from ptrivedi December 15, 2025 17:40
@ptrivedi ptrivedi marked this pull request as ready for review December 15, 2025 18:35
@ptrivedi ptrivedi force-pushed the user/ptrivedi/cont-network-mode branch 3 times, most recently from 87b7671 to 606dc8d Compare December 15, 2025 20:08
@ptrivedi ptrivedi closed this Dec 15, 2025
@ptrivedi ptrivedi deleted the copilot/sub-pr-13886-yet-again branch December 15, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants