Followup fixes from the persistent sessions change #14061
+49
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses follow-up feedback from PR #14047, which introduced persistent sessions. The main change is refactoring the MapVmPort API to separate mapping and unmapping operations into two distinct methods: MapVmPort (for creating port mappings) and UnmapVmPort (for removing them). Previously, a single MapVmPort method with a boolean Remove parameter handled both operations.
Changes:
- Split the
MapVmPortAPI into separateMapVmPortandUnmapVmPortmethods in the IDL interface, session layer, and virtual machine layer - Updated all call sites in tests and container implementation to use the appropriate method
- Added internal
MapPortImplhelper that continues to use the unified wire protocol with aStopflag - Added test coverage to validate that
WSLASessionFlagsOpenExistingcreates a new session when no matching session exists
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/windows/wslaservice/inc/wslaservice.idl | Split MapVmPort into separate MapVmPort and UnmapVmPort methods in the COM interface |
| src/windows/wslaservice/exe/WSLAVirtualMachine.h | Added MapPort, UnmapPort, and private MapPortImpl method declarations |
| src/windows/wslaservice/exe/WSLAVirtualMachine.cpp | Implemented separate MapPort and UnmapPort methods that delegate to MapPortImpl |
| src/windows/wslaservice/exe/WSLASession.h | Updated interface declarations for MapVmPort and UnmapVmPort |
| src/windows/wslaservice/exe/WSLASession.cpp | Implemented separate MapVmPort and UnmapVmPort methods |
| src/windows/wslaservice/exe/WSLAContainer.cpp | Updated container port mapping cleanup to use UnmapPort instead of MapPort with true flag |
| test/windows/WSLATests.cpp | Updated test calls to use UnmapVmPort for unmapping operations and added test for session creation with WSLASessionFlagsOpenExisting |
6 tasks
benhillis
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This change addresses comments that were published after #14047 was merged
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed