Fix issue with svccommio incorrectly resetting console state in the move operator #14083
+30
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ove operator The ConsoleInput and ConsoleOutput classes used = default move operations, which caused the moved-from temporary's destructor to restore the original console mode (re-enabling ENABLE_PROCESSED_INPUT) after the object was moved into the std::optional. The fix uses emplace() to construct objects directly in-place, avoiding moves entirely. Move operations are now deleted to prevent future misuse.
benhillis
requested review from
Brian-Perkins,
OneBlue,
Copilot,
craigloewen-msft and
justus-camp-microsoft
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a bug where ConsoleInput and ConsoleOutput RAII classes incorrectly restored the original console mode due to default move operations. When objects were moved into std::optional, the moved-from object's destructor would reset the console state, causing the console mode to be incorrectly restored.
Changes:
- Deleted move constructors and move assignment operators for
ConsoleInputandConsoleOutputto prevent future misuse - Changed from factory pattern (static
Create()methods with private constructors) to direct construction with public constructors - Updated
SvcCommIoconstructor to useemplace()for in-place construction, avoiding move operations entirely
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/windows/common/svccommio.hpp | Made constructors public, deleted move operations, updated member initialization to use brace-initialization |
| src/windows/common/svccommio.cpp | Removed Create() factory methods, moved code page initialization to member initializer lists, updated SvcCommIo constructor to use emplace() for in-place construction |
OneBlue
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken by #13843.
The ConsoleInput and ConsoleOutput classes used = default move operations, which caused the moved-from temporary's destructor to restore the original console mode (re-enabling ENABLE_PROCESSED_INPUT) after the object was moved into the std::optional. The fix uses emplace() to construct objects directly in-place, avoiding moves entirely. Move operations are now deleted to prevent future misuse.