Skip to content

Conversation

@Shirly8
Copy link

@Shirly8 Shirly8 commented Nov 16, 2025

Description

Fixes #6253 - Can't toggle off from the ad-hoc panel if you've toggled on in DetailsView

Changes

  • Updated onToggleVisualHelper in needs-review-card-selection-action-creator.ts to accept null payloads
  • When payload is null (called from action-creator.ts), only toggle visual helper state without trying to enable/disable visualization
  • Added test case to verify null payload handling

Testing

  • Added unit test to verify that when toggleVisualHelper is called with null, it only toggles the visual helper state and doesn't try to enable/disable the visualization
  • Existing tests continue to pass

Root Cause

When toggling the Needs Review visualization ON in DetailsView, action-creator.ts calls toggleVisualHelper.invoke(null) to sync the visual helper state. However, onToggleVisualHelper was trying to access payload.enabled which doesn't exist when payload is null, causing the toggle to get stuck in the ad-hoc panel.

@Shirly8 Shirly8 requested a review from a team as a code owner November 16, 2025 01:06
@Shirly8
Copy link
Author

Shirly8 commented Nov 18, 2025

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't toggle off from the ad-hoc panel if you've toggled on in DetailsView

1 participant