-
Notifications
You must be signed in to change notification settings - Fork 891
.NET: Fix JailbreakSyncExecutor and FinalOutputExecutor to use List<C… #2717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rezaghadimim
wants to merge
4
commits into
microsoft:main
Choose a base branch
from
rezaghadimim:fix/sample-mixed-workflow-with-agents-and-executors
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+12
−7
Open
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d44d822
.NET: Fix JailbreakSyncExecutor and FinalOutputExecutor to use List<C…
4615329
Update dotnet/samples/GettingStarted/Workflows/_Foundational/07_Mixed…
rezaghadimim bf0c925
Update dotnet/samples/GettingStarted/Workflows/_Foundational/07_Mixed…
rezaghadimim f2d4c01
Fix null handling in assistant text output in Program.cs
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -230,14 +230,15 @@ public override async ValueTask HandleAsync(string message, IWorkflowContext con | |
| /// Executor that synchronizes agent output and prepares it for the next stage. | ||
| /// This demonstrates how executors can process agent outputs and forward to the next agent. | ||
| /// </summary> | ||
| internal sealed class JailbreakSyncExecutor() : Executor<ChatMessage>("JailbreakSync") | ||
| internal sealed class JailbreakSyncExecutor() : Executor<List<ChatMessage>>("JailbreakSync") | ||
| { | ||
| public override async ValueTask HandleAsync(ChatMessage message, IWorkflowContext context, CancellationToken cancellationToken = default) | ||
| public override async ValueTask HandleAsync(List<ChatMessage> message, IWorkflowContext context, CancellationToken cancellationToken = default) | ||
| { | ||
| Console.WriteLine(); // New line after agent streaming | ||
| Console.ForegroundColor = ConsoleColor.Magenta; | ||
|
|
||
| string fullAgentResponse = message.Text?.Trim() ?? "UNKNOWN"; | ||
| ChatMessage agentResponse = message.LastOrDefault(m => m.Role.Equals(ChatRole.Assistant), new (ChatRole.Assistant, "UNKNOWN")); | ||
rezaghadimim marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| string fullAgentResponse = agentResponse.Text.Trim(); | ||
rezaghadimim marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| Console.WriteLine($"[{this.Id}] Full Agent Response:"); | ||
| Console.WriteLine(fullAgentResponse); | ||
|
|
@@ -278,17 +279,18 @@ public override async ValueTask HandleAsync(ChatMessage message, IWorkflowContex | |
| /// <summary> | ||
| /// Executor that outputs the final result and marks the end of the workflow. | ||
| /// </summary> | ||
| internal sealed class FinalOutputExecutor() : Executor<ChatMessage, string>("FinalOutput") | ||
| internal sealed class FinalOutputExecutor() : Executor<List<ChatMessage>, string>("FinalOutput") | ||
| { | ||
| public override ValueTask<string> HandleAsync(ChatMessage message, IWorkflowContext context, CancellationToken cancellationToken = default) | ||
| public override ValueTask<string> HandleAsync(List<ChatMessage> message, IWorkflowContext context, CancellationToken cancellationToken = default) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment as above |
||
| { | ||
| var lastMessage = message.LastOrDefault(m => m.Role.Equals(ChatRole.Assistant), new ChatMessage(ChatRole.Assistant, string.Empty)); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment as above? |
||
| Console.WriteLine(); // New line after agent streaming | ||
| Console.ForegroundColor = ConsoleColor.Green; | ||
| Console.WriteLine($"\n[{this.Id}] Final Response:"); | ||
| Console.WriteLine($"{message.Text}"); | ||
| Console.WriteLine($"{lastMessage.Text}"); | ||
| Console.WriteLine("\n[End of Workflow]"); | ||
| Console.ResetColor(); | ||
|
|
||
| return ValueTask.FromResult(message.Text ?? string.Empty); | ||
| return ValueTask.FromResult(lastMessage.Text ?? string.Empty); | ||
rezaghadimim marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming the parameter
messageswould be better as it is not a list