-
Notifications
You must be signed in to change notification settings - Fork 891
.NET: Fix JailbreakSyncExecutor and FinalOutputExecutor to use List<C… #2717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
d44d822
4615329
bf0c925
f2d4c01
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -230,14 +230,15 @@ public override async ValueTask HandleAsync(string message, IWorkflowContext con | |
| /// Executor that synchronizes agent output and prepares it for the next stage. | ||
| /// This demonstrates how executors can process agent outputs and forward to the next agent. | ||
| /// </summary> | ||
| internal sealed class JailbreakSyncExecutor() : Executor<ChatMessage>("JailbreakSync") | ||
| internal sealed class JailbreakSyncExecutor() : Executor<List<ChatMessage>>("JailbreakSync") | ||
| { | ||
| public override async ValueTask HandleAsync(ChatMessage message, IWorkflowContext context, CancellationToken cancellationToken = default) | ||
| public override async ValueTask HandleAsync(List<ChatMessage> message, IWorkflowContext context, CancellationToken cancellationToken = default) | ||
| { | ||
| Console.WriteLine(); // New line after agent streaming | ||
| Console.ForegroundColor = ConsoleColor.Magenta; | ||
|
|
||
| string fullAgentResponse = message.Text?.Trim() ?? "UNKNOWN"; | ||
| ChatMessage agentResponse = message.LastOrDefault(m => m.Role.Equals(ChatRole.Assistant), new ChatMessage(ChatRole.Assistant, string.Empty)); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Rather than |
||
| string fullAgentResponse = agentResponse.Text?.Trim() ?? "UNKNOWN"; | ||
|
|
||
| Console.WriteLine($"[{this.Id}] Full Agent Response:"); | ||
| Console.WriteLine(fullAgentResponse); | ||
|
|
@@ -278,17 +279,21 @@ public override async ValueTask HandleAsync(ChatMessage message, IWorkflowContex | |
| /// <summary> | ||
| /// Executor that outputs the final result and marks the end of the workflow. | ||
| /// </summary> | ||
| internal sealed class FinalOutputExecutor() : Executor<ChatMessage, string>("FinalOutput") | ||
| internal sealed class FinalOutputExecutor() : Executor<List<ChatMessage>, string>("FinalOutput") | ||
| { | ||
| public override ValueTask<string> HandleAsync(ChatMessage message, IWorkflowContext context, CancellationToken cancellationToken = default) | ||
| public override ValueTask<string> HandleAsync(List<ChatMessage> message, IWorkflowContext context, CancellationToken cancellationToken = default) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment as above |
||
| { | ||
| var lastMessage = message.LastOrDefault(m => m.Role.Equals(ChatRole.Assistant), new ChatMessage(ChatRole.Assistant, string.Empty)); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment as above? |
||
| Console.WriteLine(); // New line after agent streaming | ||
| Console.ForegroundColor = ConsoleColor.Green; | ||
| Console.WriteLine($"\n[{this.Id}] Final Response:"); | ||
| Console.WriteLine($"{message.Text}"); | ||
| // Safely print the assistant text - normalize null to empty string before printing and returning. | ||
| string assistantText = lastMessage.Text ?? string.Empty; | ||
| Console.WriteLine(assistantText); | ||
| Console.WriteLine("\n[End of Workflow]"); | ||
| Console.ResetColor(); | ||
|
|
||
| return ValueTask.FromResult(message.Text ?? string.Empty); | ||
| // Ensure we never return null | ||
| return ValueTask.FromResult(assistantText); | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming the parameter
messageswould be better as it is not a list