-
Notifications
You must be signed in to change notification settings - Fork 891
.NET: [Breaking] Introduce RunCoreAsync/RunCoreStreamingAsync delegation pattern in AIAgent #2749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
22
commits into
main
Choose a base branch
from
copilot/make-run-methods-non-abstract
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+372
−257
Open
Changes from 8 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
8b23f71
Initial plan
Copilot 322052e
Refactor AIAgent: Make RunAsync and RunStreamingAsync non-abstract, a…
Copilot dc987ed
Fix infinite recursion in test implementations
Copilot cef4fa8
Make RunAsync and RunStreamingAsync non-virtual as requested
Copilot 6f8fb49
Fix DelegatingAIAgent subclasses to use RunCoreAsync/RunCoreStreaming…
Copilot 95bfe14
Fix XML documentation references in AnonymousDelegatingAIAgent
Copilot 04fdb4c
Restore <see cref> tags with proper qualified signatures in Anonymous…
Copilot c1ed679
Rollback unnecessary XML documentation changes in AnonymousDelegating…
Copilot df1ea8d
Remove pragma and update crefs to RunCoreAsync/RunCoreStreamingAsync
Copilot c295c14
Merge branch 'main' into copilot/make-run-methods-non-abstract
SergeyMenshykh c9b93f4
Fix EntityAgentWrapper to call base.RunCoreAsync/RunCoreStreamingAsync
Copilot 207f1d6
fix compilation issues
SergeyMenshykh f880427
Merge branch 'main' into copilot/make-run-methods-non-abstract
SergeyMenshykh 5817f3b
fix compilatio issue
SergeyMenshykh 94e70ea
Merge branch 'copilot/make-run-methods-non-abstract' of https://githu…
SergeyMenshykh a85b590
fix tests
SergeyMenshykh 00eca8b
fix unit tests
SergeyMenshykh 90021bf
Merge branch 'main' into copilot/make-run-methods-non-abstract
SergeyMenshykh ece7787
fix unit test
SergeyMenshykh e9cfa1c
Merge branch 'copilot/make-run-methods-non-abstract' of https://githu…
SergeyMenshykh a8449e5
Merge branch 'main' into copilot/make-run-methods-non-abstract
SergeyMenshykh f0300e3
Merge branch 'main' into copilot/make-run-methods-non-abstract
crickman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.