fix: Remove bundles from foundation registry in bundle remove command #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bundle_remove() function now properly removes bundles from both the user registry and the foundation registry, ensuring complete cleanup. This fixes an issue where bundles remained in registry.json after removal. Uses the new unregister() method from foundation's BundleRegistry to ensure bundles are fully removed from all registry locations. 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <[email protected]>
Member
Author
|
Closing as duplicate of #37 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
bundle_remove()function to properly remove bundles from both user registry and foundation registryregistry.jsonafter removalunregister()method from foundation's BundleRegistry for complete cleanupRelated PRs
This PR depends on the companion PR in amplifier-foundation:
Both PRs must be merged together to fully fix the
amplifier bundle removebug.Test plan
🤖 Generated with Amplifier
Co-Authored-By: Amplifier [email protected]