Skip to content

[release17.0.x] Update rush.json version #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2025
Merged

Conversation

MSNev
Copy link
Contributor

@MSNev MSNev commented Mar 10, 2025

  • Update to support internal build security requirements

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR updates multiple Rush installation scripts to support internal build security requirements and improve consistency with the new build tooling. Key changes include:

  • Refactoring of module imports and usage of webpack bootstrapping across various install-run scripts.
  • Replacement of some legacy commands with updated commands (e.g. in CI workflows, using “update --full --recheck” instead of “install”).
  • Updates to error messages and logging references to use RUSH_JSON_FILENAME for clarity.

Reviewed Changes

File Description
common/scripts/install-run-rush-silent.js Removed legacy preamble and updated import usage with webpack modules and revised logging messages.
common/scripts/install-run-rush.js Updated import references and logging messages, especially to use new constants and helper functions.
common/scripts/install-run-rushx.js Added license headers and updated comments for consistency.
.github/workflows/ci.yml Changed command invocations to use the updated “update --full --recheck” argument.
common/scripts/install-run.js Refactored npmrc utility calls and updated spawnSync options for cross-platform support.

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

common/scripts/install-run.js:67

  • The updated _trimNpmrcFile function returns an array of lines instead of a single string, which may break downstream consumers expecting a joined string. Consider joining the resultLines with a newline (e.g. resultLines.join('\n')) before returning.
return resultLines;

@MSNev MSNev merged commit 14e9de3 into release17.0.x Mar 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants