-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue #2880: Document the usage of the AAD auth #2941
base: main
Are you sure you want to change the base?
Conversation
Added the document for the usage of AAD !
@microsoft-github-policy-service agree |
@ekzhu Can you please review this? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @prithvi2226 , the docs look good to me. But I think it should be inserted in another position. Maybe in the end of section Introduction to config_list
. One more thing is that the steps may change in the future, would it be better to just put a link to the original docs in Azure OpenAI instead of having all the details here?
Head branch was pushed to by a user without write access
Co-authored-by: Qingyun Wu <[email protected]>
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
11616921 | Triggered | Generic High Entropy Secret | 394561b | notebook/agentchat_agentops.ipynb | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Why are these changes needed?
The change involves adding detailed documentation to the llm_configuration.ipynb notebook in the Microsoft Autogen repository. This documentation explains how to configure and use Azure Active Directory (AAD) authentication for Azure OpenAI services within the AutoGen.
Problem This Solves
Previously, the documentation did not include instructions for setting up AAD authentication, which is essential for secure access to Azure resources. By adding this documentation, contributors and users of the AutoGen project will have a clear, step-by-step guide to configure AAD authentication. This ensures secure and seamless integration with Azure OpenAI services, improving the usability and security of the project.
Related issue number
#2880, #2879
Checks