Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook optional user input #2961

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

MarianoMolina
Copy link
Contributor

Why are these changes needed?

I've noticed a few threads online asking about how to enable the agents to ask for user input, so I created this notebook that uses a similar StateFlow example to other ChatGroup notebooks, but adds a keyphrase to the system prompts and checks for it in the speaker_selection_method() to optionally ask the user for feedback if the agent needs help.

Related issue number

Answers: #1288

Checks

Copy link

gitguardian bot commented Jun 18, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10404662 Triggered Generic CLI Secret eff19ac .github/workflows/dotnet-release.yml View secret
10404662 Triggered Generic CLI Secret e973ac3 .github/workflows/dotnet-release.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@MarianoMolina
Copy link
Contributor Author

I think there are some base branch discrepancies, my commit seems to be making changes despite me fetching main and just adding the notebook file. I've tried a few times to ensure the commit is clean, and its still these 2 files for some reason.

Copy link

@ricardosardenberg ricardosardenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are lines that make this code not safe, example:
llm_config = {"config_list": [{"model": "mock", "api_key": "mock"}]}

one option:

llm_config = {
"config_list": [
{
"model": os.getenv("MODEL_NAME"),
"api_key": os.getenv("API_KEY")
}
]
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants