Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update method name in GeminiClient #3007

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sugatoray
Copy link

@sugatoray sugatoray commented Jun 24, 2024

  • Change GeminiClient method name from _initialize_vartexai to _initialize_vertexai.
  • Why? vartexai is a typo. It should be vertextai instead. This PR fixes that.

Checks

- change from `_initialize_vartexai` to `_initialize_vertexai`
@sugatoray sugatoray marked this pull request as ready for review June 24, 2024 08:35
@Hk669 Hk669 requested a review from BeibinLi June 24, 2024 16:14
@BeibinLi
Copy link
Collaborator

@sugatoray Thanks for fixing the typo!~

@sugatoray
Copy link
Author

sugatoray commented Jun 24, 2024

@BeibinLi I see the tests are failing for a different reason apparently. Can you please go ahead and merge the PR if it looks okay to you?

@BeibinLi BeibinLi enabled auto-merge June 24, 2024 23:14
@Hk669
Copy link
Collaborator

Hk669 commented Jun 25, 2024

@BeibinLi I see the tests are failing for a different reason apparently. Can you please go ahead and merge the PR if it looks okay to you?

once the LLamaIndexAgent tests are fixed we'll merge this PR. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants