Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix log_function_use warning #3018

Merged
merged 1 commit into from
Jun 28, 2024
Merged

fix log_function_use warning #3018

merged 1 commit into from
Jun 28, 2024

Conversation

Hk669
Copy link
Collaborator

@Hk669 Hk669 commented Jun 25, 2024

Why are these changes needed?

affected the complete groupchat of the AutoGen, showing the warning to [runtime_logging] log_function_use: autogen logger is None

Related issue number

Closes #2911

Screenshots

image

Checks

Copy link
Collaborator

@thinkall thinkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@sonichi
Copy link
Collaborator

sonichi commented Jun 25, 2024

@colombod could you take a look at the failing tests of llama-index? https://github.com/microsoft/autogen/actions/runs/9656849470/job/26635080470?pr=3018
This PR doesn't change anything related to it.

@sonichi sonichi requested a review from colombod June 25, 2024 16:22
@marklysze
Copy link
Collaborator

Testing looked good, thanks!

@Hk669
Copy link
Collaborator Author

Hk669 commented Jun 27, 2024

@colombod could you take a look at the failing tests of llama-index? https://github.com/microsoft/autogen/actions/runs/9656849470/job/26635080470?pr=3018
This PR doesn't change anything related to it.

@sonichi, is anyone working on this issue?

@colombod
Copy link
Collaborator

@colombod could you take a look at the failing tests of llama-index? https://github.com/microsoft/autogen/actions/runs/9656849470/job/26635080470?pr=3018
This PR doesn't change anything related to it.

@sonichi, is anyone working on this issue?

That is pretty awkward, it seems that llamaindex is not installed before running the test. but in this pr i don't see any changes to the environments

@Hk669
Copy link
Collaborator Author

Hk669 commented Jun 28, 2024

@colombod could you take a look at the failing tests of llama-index? https://github.com/microsoft/autogen/actions/runs/9656849470/job/26635080470?pr=3018
This PR doesn't change anything related to it.

@sonichi, is anyone working on this issue?

That is pretty awkward, it seems that llamaindex is not installed before running the test. but in this pr i don't see any changes to the environments

This PR is not related to it. Please make a new PR for the llamaindex tests failure @colombod . Thanks

@qingyun-wu qingyun-wu added this pull request to the merge queue Jun 28, 2024
Merged via the queue into main with commit 55cc542 Jun 28, 2024
114 of 131 checks passed
@qingyun-wu qingyun-wu deleted the fix-log branch June 28, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: log_function_use: autogen logger is None
6 participants