Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse and correctly set Gemini safety settings #3026

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

drewgillson
Copy link

Why are these changes needed?

The provided example at the top of this file did not work correctly. Safety settings need to be parsed into Vertex AI objects and cannot just be a dictionary of simple objects.

Checks

@drewgillson
Copy link
Author

@microsoft-github-policy-service agree

@qingyun-wu qingyun-wu requested a review from BeibinLi June 27, 2024 17:08
@qingyun-wu
Copy link
Collaborator

@drewgillson thanks for the contribution, could you fix the code formatting issue by running pre-commit? Thanks!
@BeibinLi could you help review? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants