Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Structured output with tool calls for OpenAIChatCompletionClient #5671

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ekzhu
Copy link
Collaborator

@ekzhu ekzhu commented Feb 23, 2025

Resolves: #5568

Also, refactored some unit tests.

Integration tests against OpenAI endpoint passed: https://github.com/microsoft/autogen/actions/runs/13484492096

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Copy link

codecov bot commented Feb 23, 2025

Codecov Report

Attention: Patch coverage is 85.54217% with 12 lines in your changes missing coverage. Please review.

Project coverage is 75.58%. Comparing base (a226966) to head (10a0a71).

Files with missing lines Patch % Lines
...xt/src/autogen_ext/models/openai/_openai_client.py 85.54% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5671      +/-   ##
==========================================
+ Coverage   75.56%   75.58%   +0.02%     
==========================================
  Files         171      171              
  Lines       10483    10511      +28     
==========================================
+ Hits         7921     7945      +24     
- Misses       2562     2566       +4     
Flag Coverage Δ
unittests 75.58% <85.54%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenAIChatCompletionClient's create_stream is not compatible with structured output
1 participant