Corrected condition for check value in itemPattern (#3732)

microsoft · Feb 3, 2022 · 0940cd3 · 0940cd3
1 parent b698b29
commit 0940cd3
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/Agent.Plugins/BuildArtifact/BuildArtifactPluginV1.cs b/src/Agent.Plugins/BuildArtifact/BuildArtifactPluginV1.cs
@@ -115,7 +115,7 @@ protected override async Task ProcessCommandInternalAsync(
             targetPath = Path.IsPathFullyQualified(targetPath) ? targetPath : Path.GetFullPath(Path.Combine(defaultWorkingDirectory, targetPath));
 
             // Empty input field "Matching pattern" must be recognised as default value '**'
-            itemPattern = itemPattern.Length == 0 ? "**" : itemPattern;
+            itemPattern = string.IsNullOrEmpty(itemPattern) ? "**" : itemPattern;
 
             string[] minimatchPatterns = itemPattern.Split(
                 new[] { "\n" },

diff --git a/src/Agent.Plugins/PipelineArtifact/PipelineArtifactPluginV1.cs b/src/Agent.Plugins/PipelineArtifact/PipelineArtifactPluginV1.cs
@@ -227,7 +227,7 @@ protected override async Task ProcessCommandInternalAsync(
             string userSpecifiedpipelineId = context.GetInput(PipelineId, required: false);
 
             // Empty input field "Matching pattern" must be recognised as default value '**'
-            itemPattern = itemPattern.Length == 0 ? "**" : itemPattern;
+            itemPattern = string.IsNullOrEmpty(itemPattern) ? "**" : itemPattern;
 
             string[] minimatchPatterns = itemPattern.Split(
                 new[] { "\n" },

diff --git a/src/Agent.Plugins/PipelineArtifact/PipelineArtifactPluginV2.cs b/src/Agent.Plugins/PipelineArtifact/PipelineArtifactPluginV2.cs
@@ -109,7 +109,7 @@ protected override async Task ProcessCommandInternalAsync(
             context.Debug($"ArtifactName: {artifactName}");
 
             // Empty input field "Matching pattern" must be recognised as default value '**'
-            itemPattern = itemPattern.Length == 0 ? "**" : itemPattern;
+            itemPattern = string.IsNullOrEmpty(itemPattern) ? "**" : itemPattern;
 
             string[] minimatchPatterns = itemPattern.Split(
                 new[] { "\n" },