Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup BlobStoreClientSettings and associated Agent Knob #4696

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Cleanup BlobStoreClientSettings and associated Agent Knob #4696

wants to merge 3 commits into from

Conversation

b-barthel
Copy link
Contributor

  1. Make the BlobstoreClientSettings constructor take an IKnobValueContext so we can centralize handling agent knobs instead of sprinkling it into the class methods.
  2. Remove now unneeded method parameters from DedupManifestClientFactory and BlobstoreClientSettings
  3. Default the AgentEnablePipelineArtifactLargeChunkSize knob to true

@b-barthel b-barthel changed the title Cleanup Agent Knob for Pipeline Artifacts Cleanup BlobStoreClientSettings and associated Agent Knob Mar 7, 2024
@b-barthel b-barthel added the misc Miscellaneous Changes label Mar 7, 2024
@b-barthel b-barthel marked this pull request as ready for review March 7, 2024 18:35
@b-barthel b-barthel requested review from a team as code owners March 7, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fadnavistanmay fadnavistanmay fadnavistanmay approved these changes

Assignees
No one assigned
Labels
misc Miscellaneous Changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@b-barthel @fadnavistanmay