Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use caller node installation (containerHandler) #4999

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheCrazyKing
Copy link

Hi,

I always experience issues when I run dockerized jobs in my Azure DevOps pipeline. The issue being that the docker image does not find the node installation path that the containerHandlerInvoker.js expects. I have, however, found a way to solve my issues.

var handler = process.execPath; //stdinData.handler;

Instead of using the handler from the stdin, we use the handler directly from the caller node. As such, my docker containers do not need to have the exact node version installed at the given path.

Now, I can easily apply this if I run a local agent. However, for the default agents, it's more involved to get in the way.

This is why I propose a PR. If you see another fix, or if I'm wrong, I'd be glad to hear why 👍🏼

I feel like the steps should be able to run if process.execPath resolves to a correct node path, even if stdinData.handler does not.

Cheers

@TheCrazyKing TheCrazyKing requested review from a team as code owners September 19, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant