shared dep types

change/beachball-b14f577b-da9c-4db3-9cd8-f0d6fba25af8.json

@@ -1,6 +1,6 @@
 {
   "type": "patch",
-  "comment": "Internal refactoring: remove dependents from BumpInfo",
+  "comment": "Use a shared list of considered dependency types",
   "packageName": "beachball",
   "email": "[email protected]",
   "dependentChangeType": "patch"

src/bump/getDependentsForPackages.ts

@@ -1,6 +1,5 @@
 import type { BumpInfo, PackageDependents } from '../types/BumpInfo';
-
-const depTypes = ['dependencies', 'devDependencies', 'peerDependencies', 'optionalDependencies'] as const;
+import { consideredDependencies } from '../types/PackageInfo';
 
 /**
  * Gets dependents for all packages (child points to parents): if A depends on B, then `{B: [A]}`
@@ -20,7 +19,7 @@ export function getDependentsForPackages(
       continue;
     }
 
-    for (const depType of depTypes) {
+    for (const depType of consideredDependencies) {
       for (const dep of Object.keys(info[depType] || {})) {
         if (packageInfos[dep]) {
           dependents[dep] ??= [];

src/bump/performBump.ts

@@ -4,7 +4,7 @@ import { unlinkChangeFiles } from '../changefile/unlinkChangeFiles';
 import { writeChangelog } from '../changelog/writeChangelog';
 import { BumpInfo } from '../types/BumpInfo';
 import { BeachballOptions } from '../types/BeachballOptions';
-import { PackageInfos, PackageJson } from '../types/PackageInfo';
+import { PackageInfos, PackageJson, consideredDependencies } from '../types/PackageInfo';
 import { findProjectRoot } from 'workspace-tools';
 import { npm } from '../packageManager/npm';
 import { packageManager } from '../packageManager/packageManager';
@@ -23,7 +23,7 @@ export function writePackageJson(modifiedPackages: Set<string>, packageInfos: Pa
       packageJson.version = info.version;
     }
 
-    for (const depKind of ['dependencies', 'devDependencies', 'peerDependencies', 'optionalDependencies'] as const) {
+    for (const depKind of consideredDependencies) {
       // updatedDeps contains all of the dependencies in the bump info since the beginning of a build job
       const updatedDepsVersions = info[depKind];
       if (updatedDepsVersions) {

src/bump/setDependentVersions.ts

@@ -1,6 +1,6 @@
 import type { BeachballOptions } from '../types/BeachballOptions';
 import { BumpInfo } from '../types/BumpInfo';
-import type { PackageInfos } from '../types/PackageInfo';
+import { consideredDependencies, type PackageInfos } from '../types/PackageInfo';
 import { bumpMinSemverRange } from './bumpMinSemverRange';
 
 /**
@@ -21,12 +21,8 @@ export function setDependentVersions(
       continue; // out of scope
     }
 
-    for (const deps of [info.dependencies, info.devDependencies, info.peerDependencies, info.optionalDependencies]) {
-      if (!deps) {
-        continue; // package doesn't have this dep type
-      }
-
-      for (const [dep, existingVersionRange] of Object.entries(deps)) {
+    for (const depType of consideredDependencies) {
+      for (const [dep, existingVersionRange] of Object.entries(info[depType] || {})) {
         const depPackage = packageInfos[dep];
         if (!depPackage) {
           continue; // external dependency

src/publish/performPublishOverrides.ts

@@ -1,6 +1,6 @@
 import * as fs from 'fs-extra';
 import { getWorkspaceRange } from '../packageManager/getWorkspaceRange';
-import type { PackageInfos, PackageJson, PublishConfig } from '../types/PackageInfo';
+import { consideredDependencies, type PackageInfos, type PackageJson, type PublishConfig } from '../types/PackageInfo';
 
 const acceptedKeys: (keyof PublishConfig)[] = [
   'types',
@@ -46,8 +46,8 @@ function performPublishConfigOverrides(packageJson: PackageJson): void {
  * replacement.
  */
 function performWorkspaceVersionOverrides(packageJson: PackageJson, packageInfos: PackageInfos): void {
-  const { dependencies, devDependencies, peerDependencies, optionalDependencies } = packageJson;
-  for (const deps of [dependencies, devDependencies, peerDependencies, optionalDependencies]) {
+  for (const depType of consideredDependencies) {
+    const deps = packageJson[depType];
     if (!deps) continue;
 
     for (const [depName, depVersion] of Object.entries(deps)) {

src/types/PackageInfo.ts

@@ -64,3 +64,11 @@ export interface PackageGroupsInfo {
 }
 
 export type PackageGroups = { [groupName: string]: PackageGroupsInfo };
+
+/** Types of dependencies to consider when bumping. */
+export const consideredDependencies = [
+  'dependencies',
+  'devDependencies',
+  'peerDependencies',
+  'optionalDependencies',
+] as const;