Refactor PE load error option handling

Changed property name from `ignorePELoadErrors` to `ignorePELoadError` in `AnalyzeOptions.cs`. Updated help text accordingly. Added handling for the `--ignorePELoadError` command-line argument in `BinSkim.cs` to evaluate its value and add "True" if necessary.
microsoft · Feb 21, 2025 · ee1b40c · ee1b40c
1 parent 66ce0fc
commit ee1b40c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/BinSkim.Driver/AnalyzeOptions.cs b/src/BinSkim.Driver/AnalyzeOptions.cs
@@ -54,7 +54,7 @@ public class AnalyzeOptions : AnalyzeOptionsBase
         public bool? IgnorePdbLoadError { get; set; }
 
         [Option(
-            "ignorePELoadErrors",
+            "ignorePELoadError",
             HelpText = "If enabled, BinSkim won't break if we have a ExceptionInCanAnalyzeError")]
         public bool? IgnorePELoadError { get; set; }
 

diff --git a/src/BinSkim.Driver/BinSkim.cs b/src/BinSkim.Driver/BinSkim.cs
@@ -79,6 +79,15 @@ private static string[] RewriteArgs(string[] args)
 
                         break;
                     }
+                    case "--ignorePELoadError":
+                    {
+                        if (!EvaluatesToTrueOrFalse(next))
+                        {
+                            rewritten.Add("True");
+                        }
+
+                        break;
+                    }
 
                     default:
                     {