Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6826] Add CloudAdapter for WebApi #6827

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sw-joelmut
Copy link
Collaborator

Fixes #6826

Description

This PR moves configuration classes from AspNetCore integration to Connector. Additionally, it adds CloudAdapter to WebApi integration.

Specific Changes

  • Move Configuration* classes from AspNetCore integration to Connector. Additionally, it uses TypeForwardedTo system to avoid duplications and breaking changes.
  • Added CloudAdapter class to WebApi integration. Adapted implementation of AspNetCore integration.
  • Configuration* classes marked as deprecated in WebApi.
  • Added unit tests for the new CloudAdapter class in WebApi.

Testing

The following image shows CloudAdapter with a WebApi bot working.
image

@sw-joelmut sw-joelmut requested a review from tracyboehrer July 26, 2024 13:43
@sw-joelmut sw-joelmut requested a review from a team as a code owner July 26, 2024 13:43
@sw-joelmut sw-joelmut added the Automation: No parity PR does not need to be applied to other languages. label Jul 26, 2024
@BruceHaley
Copy link
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation: No parity PR does not need to be applied to other languages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CloudAdapter for WebApi
2 participants