This repository has been archived by the owner on Dec 4, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 115
[CloudAdapter] Port CloudAdapter to Java #1296
Open
ldardick
wants to merge
28
commits into
microsoft:main
Choose a base branch
from
southworks:external/feature/southworks/cloudadapter/base
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[CloudAdapter] Port CloudAdapter to Java #1296
ldardick
wants to merge
28
commits into
microsoft:main
from
southworks:external/feature/southworks/cloudadapter/base
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We added additional commits with the stabilization work done on the implementation of Specific changes
Please let us know if you have any question |
Any updates? It's been almost a year and I wonder what's keeping it from merging? |
@ldardick Hi Dick, I was wondering if you could help me understand: 1. What problem does CloudAdapter try to solve instead of BotFrameworkAdapter? 2. Why hasn't this PR been reviewed and merged after over a year? Appreciate it! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1222
Fixes #1266
Description
As the CloudAdapter component was migrated to C#, it should be added in Java with all supporting classes and make the necessary changes in the existing code to support the CloudAdapter component.
Specific Changes
mockito
inbot-integration-core
CloudAdapterWithErrorHandler
which inherits from CloudAdapter used by some Java samplesgetCloudAdapter
inBotDependencyConfiguration
to return aCloudAdapterWithErrorHandler
InvokeResponse
andTypedInvokeResponse
to bot-schema, assign old ones as deprecatedBotFrameworkClient
to bot-connector to have parity with JSTesting
mvn clean install passing correctly