Skip to content

Commit

Permalink
fix: ESLint issues in botbuilder-azure-queues (#4831)
Browse files Browse the repository at this point in the history
* fix eslint issues in botbuilder-azure-queues

* remove eslint config

* remove eslint-plugin-only-warn
  • Loading branch information
JhontSouth authored Jan 6, 2025
1 parent a36641b commit d5d82e6
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 16 deletions.
10 changes: 0 additions & 10 deletions libraries/botbuilder-azure-queues/eslint.config.cjs

This file was deleted.

5 changes: 2 additions & 3 deletions libraries/botbuilder-azure-queues/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@
},
"dependencies": {
"@azure/storage-queue": "^12.23.0",
"botbuilder-core": "4.1.6",
"eslint-plugin-only-warn": "^1.1.0"
"botbuilder-core": "4.1.6"
},
"devDependencies": {
"botbuilder-dialogs": "4.1.6",
Expand All @@ -41,7 +40,7 @@
"build-docs": "typedoc --theme markdown --entryPoint botbuilder-azure-queues --excludePrivate --includeDeclarations --ignoreCompilerErrors --module amd --out ..\\..\\doc\\botbuilder-azure-queues .\\lib\\index.d.ts --hideGenerator --name \"Bot Builder SDK - Azure Queues\" --readme none",
"clean": "rimraf _ts3.4 lib tsconfig.tsbuildinfo",
"depcheck": "depcheck --config ../../.depcheckrc",
"lint": "eslint .",
"lint": "eslint . --config ../../eslint.config.cjs",
"postbuild": "downlevel-dts lib _ts3.4/lib",
"test": "yarn build && nyc mocha --check-leaks tests",
"test:compat": "api-extractor run --verbose"
Expand Down
2 changes: 1 addition & 1 deletion libraries/botbuilder-azure-queues/src/azureQueueStorage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export class AzureQueueStorage extends QueueStorage {
async queueActivity(
activity: Partial<Activity>,
visibilityTimeout?: number,
messageTimeToLive?: number
messageTimeToLive?: number,
): Promise<string> {
await this._initialize();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ describe('AzureQueueStorage', function () {
new ContinueConversationLater().configure({
date: '=addSeconds(utcNow(), 2)',
value: 'foo',
})
}),
);

dm.initialTurnState.set(DialogTurnStateConstants.queueStorage, queueStorage);
Expand All @@ -62,7 +62,7 @@ describe('AzureQueueStorage', function () {
await adapter.send('hi').startTest();

const { receivedMessageItems } = await new Promise((resolve) => setTimeout(resolve, 2000)).then(() =>
queue.receiveMessages()
queue.receiveMessages(),
);
assert.strictEqual(receivedMessageItems.length, 1);

Expand Down

0 comments on commit d5d82e6

Please sign in to comment.