This repository was archived by the owner on Jan 5, 2026. It is now read-only.
fix: [#4797] Add recognizers-text packages as vendors#4818
Closed
sw-joelmut wants to merge 16 commits intomainfrom
Closed
fix: [#4797] Add recognizers-text packages as vendors#4818sw-joelmut wants to merge 16 commits intomainfrom
sw-joelmut wants to merge 16 commits intomainfrom
Conversation
Pull Request Test Coverage Report for Build 12420517834Details
💛 - Coveralls |
This was referenced Jan 20, 2025
# Conflicts: # yarn.lock
Bumps [tar-fs](https://github.com/mafintosh/tar-fs) from 2.1.1 to 2.1.2. - [Commits](mafintosh/tar-fs@v2.1.1...v2.1.2) --- updated-dependencies: - dependency-name: tar-fs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
@sw-joelmut Are you going to merge it? This vulnerability has been here for a couple of years. |
Collaborator
Author
Hi @tracyboehrer, Is there a plan on merging or releasing this PR? There’s attention on resolving this vulnerability, and the community would appreciate any information on the next steps. Thanks! |
Collaborator
|
Hi @tracyboehrer, conflicts are fixed in this PR. |
Member
|
This will not be addressed prior to Bot Framework SDK deprecation EOM December 2025. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4797
Description
This PR adds the recognizers-text package as a vendor dependency for BotBuilder libraries.
To achieve this behavior, we compiled the recongizers-text with 1.1.4 version, updated vulnerable dependencies, and add it as a workspace, so they are connected with BotBuilder libraries.
When publishing BotBuilder packages to npm, we created a script that copies all recognizers-text packages related to a specific BotBuilder library, installing related dependencies, and updating compiled code with the copied references.
The script will be executed post updating versions script.
Important
All recognizers-text packages under botbuilder-vendors/vendors have been compiled with tsup, reduced their package.json information, and changed the require statements to match local vendors.
Specific Changes
Testing
The following image shows an execution example of the script.
