port: SkillDialog.InterceptOAuthCardsAsync doesn't support CloudAdapter (#6848) #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… CloudAdapter in combination with expect replies delivery mode
tracyboehrer
approved these changes
Oct 18, 2024
tracyboehrer
deleted the
v-gandiddi/add-cloudadapter-support-in-oauth-exchange
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #minor
Description
This PR ports the changes from microsoft/botbuilder-dotnet#6848 to maintain parity with
microsoft/botbuilder-dotnet.This PR updates the
_intercept_oauth_cardsmethod inSkillDialogto supportCloudAdapterin combination with expect replies delivery mode.Specific Changes
_intercept_oauth_cardsadded a call to_UserTokenAccess.exchange_tokenmethod, which handles both adapters.Testing
The following image shows the related unit test passing.
