Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update permissions on deploy scripts + only run Github build workflows on relevant paths #135

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Conversation

dehoward
Copy link
Contributor

@dehoward dehoward commented Aug 8, 2023

Motivation and Context

updates deploy scripts to have execute permissions, so that they can run correctly in Github, and changes build workflows to run only when the relevant paths are updated.

Description

Contribution Checklist

@dehoward dehoward requested a review from alliscode August 8, 2023 22:15
@dehoward dehoward self-assigned this Aug 8, 2023
@github-actions github-actions bot added deployment Issues related to deploying Chat-Copilot PR: ready for review github actions Pull requests that update GitHub Actions code labels Aug 8, 2023
alliscode
alliscode previously approved these changes Aug 8, 2023
@dehoward dehoward changed the title update permissions on scripts + paths in GH flows Update permissions on deploy scripts + only run Github build workflows on relevant paths Aug 8, 2023
@dehoward dehoward added this pull request to the merge queue Aug 8, 2023
Merged via the queue into microsoft:main with commit 298985d Aug 8, 2023
@dehoward dehoward deleted the workflow-fixes branch August 8, 2023 23:08
teamleader-dev pushed a commit to vlink-group/chat-copilot that referenced this pull request Oct 7, 2024
…s on relevant paths (microsoft#135)

### Motivation and Context

<!-- Thank you for your contribution to the copilot-chat repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
updates deploy scripts to have execute permissions, so that they can run
correctly in Github, and changes build workflows to run only when the
relevant paths are updated.

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment Issues related to deploying Chat-Copilot github actions Pull requests that update GitHub Actions code
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants