UX improvements: A11y labels, fixing space input bug, enabling RLFH, etc. #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teresaqhoang
requested review from
matthewbolanos,
TaoChenOSU,
dehoward and
a team
github-actions
bot
added
webapp
alliscode
previously approved these changes
Aug 15, 2023
glahaye
reviewed
Aug 15, 2023
glahaye
previously approved these changes
Aug 15, 2023
glahaye
approved these changes
Aug 15, 2023
teamleader-dev
pushed a commit
to vlink-group/chat-copilot
that referenced
this pull request
Oct 7, 2024
…etc. (microsoft#179) ### Motivation and Context <!-- Thank you for your contribution to the copilot-chat repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> This PR contains the following UX improvements: - Fixes bug where you couldn't enter space when editing chat name on list item - Fixes auto-naming bug to match all datetime syntaxes - Removes inactive field of RLFH - users can now enable this from settings - Adds multiple A11y aria-labels and hover text - Limit privacy alert to users in Microsoft tenant only ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Persona component was conflicting with "Space" keydown behavior of ChatListItem, so I removed it. Using the `title` property on the component is sufficient to show hover text: <img width="362" alt="Screenshot 2023-08-15 at 11 22 04 AM" src="https://github.com/microsoft/chat-copilot/assets/125500434/78cf38ee-0138-485e-9ee7-cee3f2962823"> <img width="341" alt="Screenshot 2023-08-15 at 11 22 56 AM" src="https://github.com/microsoft/chat-copilot/assets/125500434/4da12ac4-f596-49c2-b863-f3b34af68988"> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [Contribution Guidelines](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md#development-scripts) raises no violations ~~- [ ] All unit tests pass, and I have added new tests where possible~~ - [x] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR contains the following UX improvements:
Description
Persona component was conflicting with "Space" keydown behavior of ChatListItem, so I removed it. Using the
titleproperty on the component is sufficient to show hover text:Contribution Checklist
- [ ] All unit tests pass, and I have added new tests where possible