Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for errors in the "array_ptr" interfaces to some libc functions declared in checkedc_extensions.h, and removal of the conditional in the snprintf declaration in stdio_checked.h #456

Merged
merged 6 commits into from
Jun 11, 2021
Merged

Fixes for errors in the "array_ptr" interfaces to some libc functions declared in checkedc_extensions.h, and removal of the conditional in the snprintf declaration in stdio_checked.h #456

merged 6 commits into from
Jun 11, 2021

Conversation

sulekhark
Copy link
Contributor

@sulekhark sulekhark commented Jun 7, 2021 •
edited
Loading

This PR contains fixes for issues #449 and #450. They are, in brief:

  1. link-time errors caused by declaring strncmp_array_ptr as extern inline,
  2. missing definition for snprintf_array_ptr, and
  3. inconsistency between the second argument of snprintf (i.e. the argument n) and the bounds declaration for the first argument of snprintf (i.e., the argument s) when n == 0.

@sulekhark sulekhark marked this pull request as draft June 7, 2021 14:24
@sulekhark sulekhark marked this pull request as ready for review June 7, 2021 16:46
@sulekhark sulekhark mentioned this pull request Jun 7, 2021
Closed
@mattmccutchen-cci mattmccutchen-cci mentioned this pull request Jun 8, 2021
Open
mgrang
mgrang reviewed Jun 10, 2021
View reviewed changes
tests/dynamic_checking/checked_headers/ext.c Outdated

#pragma CHECKED_SCOPE on

#include <stddef.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these headers be listed alphabetically?

include/checkedc_extensions.h Outdated
@@ -6,6 +6,7 @@

#include <stdlib_checked.h>
#include <string_checked.h>
#include <stdarg.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these headers be listed alphabetically?

mgrang
mgrang approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@mgrang mgrang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mgrang
Copy link
Contributor

mgrang commented Jun 10, 2021

Could you please add a title describing the changes?

kkjeer
kkjeer approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@kkjeer kkjeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sulekhark sulekhark changed the title Issues 449 450 Fixes for errors in the "array_ptr" interfaces to some libc functions declared in checkedc_extensions.h Jun 11, 2021
@mattmccutchen-cci
Copy link
Contributor

Ideally, the new PR title would encompass the removal of the conditional from snprintf (#450) as well as the checkedc_extensions.h changes (#449). Sulekha, would you be willing to change it?

mgrang
mgrang approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@mgrang mgrang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@sulekhark
Copy link
Contributor Author

Ideally, the new PR title would encompass the removal of the conditional from snprintf (#450) as well as the checkedc_extensions.h changes (#449). Sulekha, would you be willing to change it?

Yes, of course.

@sulekhark sulekhark changed the title Fixes for errors in the "array_ptr" interfaces to some libc functions declared in checkedc_extensions.h Fixes for errors in the "array_ptr" interfaces to some libc functions declared in checkedc_extensions.h, and removal of the conditional in the snprintf declaration in stdio_checked.h Jun 11, 2021
@sulekhark sulekhark merged commit 6b4a3a2 into master Jun 11, 2021
@sulekhark sulekhark deleted the issues_449_450 branch June 11, 2021 21:25
@sulekhark sulekhark mentioned this pull request Jun 15, 2021
Closed
@secure-sw-dev-bot secure-sw-dev-bot mentioned this pull request Jan 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkjeer kkjeer kkjeer approved these changes

@mgrang mgrang mgrang approved these changes

@dtarditi dtarditi Awaiting requested review from dtarditi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sulekhark @mgrang @mattmccutchen-cci @kkjeer